Skip to content

Netbird: add stunService.nodePort#73

Merged
mikkeldamsgaard merged 1 commit intoKitStream:mainfrom
DaniD3v:main
Apr 25, 2026
Merged

Netbird: add stunService.nodePort#73
mikkeldamsgaard merged 1 commit intoKitStream:mainfrom
DaniD3v:main

Conversation

@DaniD3v
Copy link
Copy Markdown
Contributor

@DaniD3v DaniD3v commented Apr 19, 2026

adds stunService.nodePort

I like specifying NodePort.
I could not do this with the existing chart.

server:
  stunService:
    type: NodePort
    port: 3478
    nodePort: 30478

Copy link
Copy Markdown
Contributor

@mikkeldamsgaard mikkeldamsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution — small, focused change and the core logic is right. One blocker before this can merge.

nodePort is missing from values.yaml. The README values table documents server.stunService.nodePort, but charts/netbird/values.yaml (the stunService block around L416–419) still only declares type, port, and annotations. The convention in this chart is that every documented value is present in values.yaml with a # -- comment — that's what users discover via helm show values, and what drives the generated values table. Please add something like:

  stunService:
    type: LoadBalancer
    port: 3478
    # -- Fixed NodePort to assign when type is NodePort. Omit/null to let
    # Kubernetes allocate one from the nodePort range (default 30000–32767).
    nodePort: null
    annotations: {}

Two non-blocking nits left inline on the test file. Happy to re-review once the values.yaml entry is in.

Comment thread charts/netbird/tests/server-stun-service_test.yaml Outdated
Comment thread charts/netbird/tests/server-stun-service_test.yaml
@DaniD3v DaniD3v force-pushed the main branch 2 times, most recently from a86b2bd to 69ed6f4 Compare April 22, 2026 18:54
@DaniD3v
Copy link
Copy Markdown
Contributor Author

DaniD3v commented Apr 22, 2026

I have implemented the requested changes

@mikkeldamsgaard
Copy link
Copy Markdown
Contributor

Unfortunately the CI pipeline fails, with formatting errors. Please address.

@DaniD3v
Copy link
Copy Markdown
Contributor Author

DaniD3v commented Apr 23, 2026

I made the text a little shorter and ran the formatter

@mikkeldamsgaard mikkeldamsgaard merged commit fe74b4a into KitStream:main Apr 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants