Netbird: add stunService.nodePort#73
Conversation
There was a problem hiding this comment.
Thanks for the contribution — small, focused change and the core logic is right. One blocker before this can merge.
nodePort is missing from values.yaml. The README values table documents server.stunService.nodePort, but charts/netbird/values.yaml (the stunService block around L416–419) still only declares type, port, and annotations. The convention in this chart is that every documented value is present in values.yaml with a # -- comment — that's what users discover via helm show values, and what drives the generated values table. Please add something like:
stunService:
type: LoadBalancer
port: 3478
# -- Fixed NodePort to assign when type is NodePort. Omit/null to let
# Kubernetes allocate one from the nodePort range (default 30000–32767).
nodePort: null
annotations: {}Two non-blocking nits left inline on the test file. Happy to re-review once the values.yaml entry is in.
a86b2bd to
69ed6f4
Compare
|
I have implemented the requested changes |
|
Unfortunately the CI pipeline fails, with formatting errors. Please address. |
|
I made the text a little shorter and ran the formatter |
adds stunService.nodePort
I like specifying
NodePort.I could not do this with the existing chart.